Bug 90767

Summary: [GTK] Inspector should set a default attached height before being attached
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Description Flags
Patch xan.lopez: review+

Description Carlos Garcia Campos 2012-07-09 03:03:43 PDT
We are currently using the minimum attached height in WebKitWebViewBase as the default height for the inspector when attached. It would be easier for WebKitWebViewBase and embedders implementing attach() if the inspector already had an attached height set when it's being attached.
Comment 1 Carlos Garcia Campos 2012-07-09 03:08:12 PDT
Created attachment 151221 [details]
Comment 2 WebKit Review Bot 2012-07-09 03:10:44 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Xan Lopez 2012-08-02 07:13:09 PDT
Comment on attachment 151221 [details]

This looks reasonable to me, but I'm not an expert in this area of the code. Maybe martin wants to have a second look.
Comment 4 Martin Robinson 2012-08-02 07:18:45 PDT
Comment on attachment 151221 [details]

This looks sane to me.
Comment 5 Carlos Garcia Campos 2012-08-02 10:44:52 PDT
Committed r124479: <http://trac.webkit.org/changeset/124479>