Summary: | [GTK] Inspector should set a default attached height before being attached | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, mrobinson, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-07-09 03:03:43 PDT
Created attachment 151221 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 151221 [details]
Patch
This looks reasonable to me, but I'm not an expert in this area of the code. Maybe martin wants to have a second look.
Comment on attachment 151221 [details]
Patch
This looks sane to me.
Committed r124479: <http://trac.webkit.org/changeset/124479> |