Bug 90765
| Summary: | garden-o-matic should refuse rebaseline for reftests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hayato Ito <hayato> |
| Component: | Tools / Tests | Assignee: | Alan Cutter <alancutter> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, dpranke, mikelawther, ojan, simon.fraser, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 69227 | ||
Hayato Ito
It might be user-friendly if garden-o-matic can refuse rebaseline for reftests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
Yes! We don't have a good meta bug to collect these feature requests, but Bug 69227 will have to do for now.
Ojan Vafai
It should already do hide the rebaseline button for reftests. Did you see a case where it doesn't?
Oh, on the main page where tests are grouped together, I suppose it still shows the rebaseline button. I was thinking that we actually need to make webkit-patch be a noop for rebaselining reftests. Fixing it at that level is better because it means that other users of the webkit-patch command will also be safe.
Hayato Ito
(In reply to comment #2)
> It should already do hide the rebaseline button for reftests. Did you see a case where it doesn't?
Yes. Yesterday, when I was gardening, I saw 'Rebaseline' button for a single test, 'fast/text-autosizing/simple-paragraph.html' on the main page. It was not grouped. As far as I remembered, I clicked a 'Rebaseline' button for the test, and I noticed it was a reftest after a patch was created by garden-o-matic.
>
> Oh, on the main page where tests are grouped together, I suppose it still shows the rebaseline button. I was thinking that we actually need to make webkit-patch be a noop for rebaselining reftests. Fixing it at that level is better because it means that other users of the webkit-patch command will also be safe.
That sounds nice. webkit-patch is a good place as a last defense.
Tony Chang
This was recently fixed.
*** This bug has been marked as a duplicate of bug 101976 ***