Bug 9073

Summary: [S60] Soft hyphen (­ and ­ and ­) is not displayed
Product: WebKit Reporter: Krishna <krishnamurty.podipireddy>
Component: TextAssignee: David Carson <dacarson>
Status: CLOSED FIXED    
Severity: Normal CC: dacarson, ian
Priority: P2 Keywords: PlatformOnly
Version: 312.x   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
soft_hyphen.html
none
patch zalan: review+

Krishna
Reported 2006-05-23 13:00:34 PDT
Character entities of soft hyphen (&shy; and &#173; and &#xAD;) are not rendered when line break occurs. Steps to reproduce: 1. Load the attached file 2. There are three paras displayed and a soft hyphen is not displayed at the line breaks. Actual result: Soft hyphen is not displayed at the end of each line. Expected result: Soft hyphen is expected at the end of each line for each paragraph; i.e. at the point at which the line wraps.
Attachments
soft_hyphen.html (1.57 KB, text/html)
2006-05-23 13:01 PDT, Krishna 		no flags
Details
patch (9.55 KB, patch)
2006-05-31 16:21 PDT, David Carson 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krishna
Comment 1 2006-05-23 13:01:05 PDT
Created attachment 8492 [details] soft_hyphen.html
David Kilzer (:ddkilzer)
Comment 2 2006-05-23 13:18:22 PDT
Interesting. In FireFox 1.5.0.3, no wrapping occurs at all! Works ask expected in MSIE 6 from WinXP SP 2. Note that there are a couple of "stray" semi-colons (without the preceding "&shy") in the "para1" line in Attachment 8492 [details].
Dave Hyatt
Comment 3 2006-05-23 19:50:30 PDT
This is S60 only presumably. The test case works fine for me in TOT Safari.
Dave Hyatt
Comment 4 2006-05-23 19:51:24 PDT
Firefox does not support soft hyphens so don't pay attention to it.
David Kilzer (:ddkilzer)
Comment 5 2006-05-24 10:31:46 PDT
(In reply to comment #4) > Firefox does not support soft hyphens so don't pay attention to it. Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=9101
Dave Hyatt
Comment 6 2006-05-25 18:20:03 PDT
I just landed a fix for this for Win32 that you can backport to S60. See my most recent change to rendering/break_lines.cpp.
David Kilzer (:ddkilzer)
Comment 7 2006-05-26 10:12:13 PDT
(In reply to comment #6) > I just landed a fix for this for Win32 that you can backport to S60. See my > most recent change to rendering/break_lines.cpp. Subversion revision r14601.
David Carson
Comment 9 2006-05-28 14:47:27 PDT
Tried the patch, and it didn't make any noticable difference in S60 emulator. Need to debug to see what is going on.
Krishna
Comment 10 2006-05-30 10:20:10 PDT
TSW Error ID: AKUR-6H9EAC
David Carson
Comment 11 2006-05-31 16:21:12 PDT
Created attachment 8631 [details] patch Patch includes updated expected results for layout tests, changelog and patch. Also includes a missing expected results file for the layout tests.
Sachin Padma
Comment 12 2006-06-05 06:53:33 PDT
r=me
alan
Comment 13 2006-06-07 07:30:09 PDT
(In reply to comment #11) > Created an attachment (id=8631) [edit] > patch > > Patch includes updated expected results for layout tests, changelog and patch. > Also includes a missing expected results file for the layout tests. > r=me
Darin Adler
Comment 14 2006-06-30 21:35:15 PDT
Adding S60 prefix to summary of platform-only bugs with reviewed patches, so we can see if there are non-S60 ones in the review queue.
Bradley Morrison
Comment 15 2006-07-26 11:27:35 PDT
Applied (r15638). Verified against latest S60WebKit via layout test with index 927 (X:\S60\LayoutTests\fast\text\basic\014.html). Many thanks!
Krishna
Comment 16 2006-07-27 09:05:27 PDT
As this is S60 only issue, verified on the S60 Webkit at r15648. The issue is no longer reproducible. Soft hyphen is displayed at the end of each line for each paragraph; i.e. at the point at which the line wraps. Resolution is set to VERIFIED.
Krishna
Comment 17 2006-07-28 10:59:34 PDT
Set to CLOSED.
Note You need to log in before you can comment on or make changes to this bug.