Bug 90705

Summary: [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
Product: WebKit Reporter: Lauro Moura Maranhao Neto <lauro.neto>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Use QImage.constBits instead of bits none

Lauro Moura Maranhao Neto
Reported 2012-07-06 14:50:16 PDT
getImageData is using non-const QImage.bits() as the first argument to packPixels, which expects a const uchar*. This is causing a deep copy of the QImage for each call.
Attachments
Use QImage.constBits instead of bits (1.66 KB, patch)
2012-07-06 14:55 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura Maranhao Neto
Comment 1 2012-07-06 14:55:02 PDT
Created attachment 151118 [details] Use QImage.constBits instead of bits
WebKit Review Bot
Comment 2 2012-07-06 15:45:12 PDT
Comment on attachment 151118 [details] Use QImage.constBits instead of bits Clearing flags on attachment: 151118 Committed r122037: <http://trac.webkit.org/changeset/122037>
WebKit Review Bot
Comment 3 2012-07-06 15:45:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.