Bug 90705

Summary:

[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()

Product:

WebKit

Reporter:

Lauro Moura Maranhao Neto <lauro.neto>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Use QImage.constBits instead of bits	none

Description Lauro Moura Maranhao Neto 2012-07-06 14:50:16 PDT

getImageData is using non-const QImage.bits() as the first argument to packPixels, which expects a const uchar*. This is causing a deep copy of the QImage for each call.

Comment 1 Lauro Moura Maranhao Neto 2012-07-06 14:55:02 PDT

Created attachment 151118 [details]
Use QImage.constBits instead of bits

Comment 2 WebKit Review Bot 2012-07-06 15:45:12 PDT

Comment on attachment 151118 [details]
Use QImage.constBits instead of bits

Clearing flags on attachment: 151118

Committed r122037: <http://trac.webkit.org/changeset/122037>

Comment 3 WebKit Review Bot 2012-07-06 15:45:16 PDT

All reviewed patches have been landed.  Closing bug.