Summary: | [Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, mrobinson, pnormand, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 87127 | ||||||||||
Attachments: |
|
Description
Zan Dobersek
2012-07-06 10:23:58 PDT
Fixing the title, the story's about GNUmakefile.list.am. Created attachment 151100 [details]
Patch
We know the preprocessor is supposed to be fast but can you provide clean build comparison times? (In reply to comment #3) > We know the preprocessor is supposed to be fast but can you provide clean build comparison times? ToT: build-webkit --gtk --no-webkit2: 38m07s build-webkit --gtk --no-webkit2 --no-svg: 30m30s With patch: build-webkit --gtk --no-webkit2: 38m19s build-webkit --gtk --no-webkit2 --no-svg: 30m57s A couple of seconds longer, but no real drawbacks time-wise. Comment on attachment 151100 [details]
Patch
Patch looks good! But can you please rebase it and upload again for EWS check?
Created attachment 151302 [details]
Patch
A rebased patch.
Created attachment 158242 [details]
Patch
Updated patch
Comment on attachment 158242 [details]
Patch
EWS didn't complain, let's try! Thanks Zan!
(In reply to comment #8) > (From update of attachment 158242 [details]) > EWS didn't complain, let's try! Thanks Zan! Thanks for the review, I'll land this carefully later today. Hopefully the patch will still apply :> Committed as http://trac.webkit.org/changeset/125583 without problems. |