Bug 90696

Summary: [Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mrobinson, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87127    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Zan Dobersek 2012-07-06 10:23:58 PDT 
Include all the WebCore source files that are guarded by ENABLE_* guards into the build, relying on proper in-source ENABLE_* guarding and the preprocessor to do the work of keeping unneeded/disabled code out of compilation.
Comment 1 Zan Dobersek 2012-07-06 10:30:38 PDT 
Fixing the title, the story's about GNUmakefile.list.am.
Comment 2 Zan Dobersek 2012-07-06 10:41:33 PDT 
Created attachment 151100 [details]
Patch
Comment 3 Philippe Normand 2012-07-06 17:14:33 PDT 
We know the preprocessor is supposed to be fast but can you provide clean build comparison times?
Comment 4 Zan Dobersek 2012-07-07 06:47:39 PDT 
(In reply to comment #3)
> We know the preprocessor is supposed to be fast but can you provide clean build comparison times?

ToT:
build-webkit --gtk --no-webkit2: 38m07s
build-webkit --gtk --no-webkit2 --no-svg: 30m30s

With patch:
build-webkit --gtk --no-webkit2: 38m19s
build-webkit --gtk --no-webkit2 --no-svg: 30m57s

A couple of seconds longer, but no real drawbacks time-wise.
Comment 5 Philippe Normand 2012-07-09 11:29:08 PDT 
Comment on attachment 151100 [details]
Patch

Patch looks good! But can you please rebase it and upload again for EWS check?
Comment 6 Zan Dobersek 2012-07-09 12:43:46 PDT 
Created attachment 151302 [details]
Patch

A rebased patch.
Comment 7 Zan Dobersek 2012-08-14 00:23:19 PDT 
Created attachment 158242 [details]
Patch

Updated patch
Comment 8 Philippe Normand 2012-08-14 02:01:06 PDT 
Comment on attachment 158242 [details]
Patch

EWS didn't complain, let's try! Thanks Zan!
Comment 9 Zan Dobersek 2012-08-14 02:10:05 PDT 
(In reply to comment #8)
> (From update of attachment 158242 [details])
> EWS didn't complain, let's try! Thanks Zan!

Thanks for the review, I'll land this carefully later today. Hopefully the patch will still apply :>
Comment 10 Zan Dobersek 2012-08-14 23:59:18 PDT 
Committed as http://trac.webkit.org/changeset/125583 without problems.