Bug 90684

Summary:

Web Inspector: get rid of cancellable records in Timeline, manage frame records explicitly

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2012-07-06 06:41:05 PDT

Bringing in a notion of generic "cancelable" records in Timeline agent was a bad idea -- we don't seem to have other uses for it, and current implementation that uses records stack is somewhat confusing. Let's manage pending frame record explicitly instead.

Attachments
Patch (7.18 KB, patch) 2012-07-06 06:53 PDT, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-07-06 06:53:30 PDT

Created attachment 151079 [details] Patch

Andrey Kosyakov

Comment 2 2012-07-06 09:41:23 PDT

Committed r121980: <http://trac.webkit.org/changeset/121980>

Note You need to log in before you can comment on or make changes to this bug.