| Summary: | Improve the logical top estimation algorithm to be right more often | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aestes, ahmad.saleem792, dglazkov, eae, eric, jchaffraix, jkp2k, psolanki, webkit-bug-importer, webkit.review.bot | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 91036 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dave Hyatt
2012-07-05 17:43:00 PDT
Created attachment 151004 [details]
Patch
Attachment 151004 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 151005 [details]
Patch
Comment on attachment 151005 [details] Patch Attachment 151005 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13151209 New failing tests: fast/block/float/previous-sibling-float-002.html Created attachment 151009 [details]
Archive of layout-test-results from gce-cr-linux-05
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 151092 [details]
Patch
Created attachment 151094 [details]
Patch
Looks like hyatt landed this: <http://trac.webkit.org/changeset/122244> It also looks like this change broke Bing Maps. I filed <https://bugs.webkit.org/show_bug.cgi?id=91036>. Comment on attachment 151005 [details] Patch Cleared Simon Fraser's review+ from obsolete attachment 151005 [details] so that this bug does not appear in http://webkit.org/pending-commit. It seems this landed: https://github.com/WebKit/WebKit/commit/4bea3befee2820ad81a0a464c17b8cf604455c05 and then had regression, which is in 'Blocks' but it was marked duplicate of bug 91000, which was fixed properly rather than backing out this change. as follow: https://github.com/WebKit/WebKit/commit/8b8e24f4cc82da16952d735b23264ecfa6d995da Marking this as 'RESOLVED FIXED'. |