Bug 90646

Summary: Improve the logical top estimation algorithm to be right more often
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ahmad.saleem792, dglazkov, eae, eric, jchaffraix, jkp2k, psolanki, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91036    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-05
none
Patch
none
Patch simon.fraser: review+

Dave Hyatt
Reported 2012-07-05 17:43:00 PDT
Improve the logical top estimation algorithm to be right more often. In particular we want to handle the basic case of <body><h1> or <body><p>.
Attachments
Patch (1.94 MB, patch)
2012-07-05 17:45 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (6.45 KB, patch)
2012-07-05 17:47 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-05 (359.61 KB, application/zip)
2012-07-05 18:27 PDT, WebKit Review Bot 		no flags
Details
Patch (10.48 KB, patch)
2012-07-06 09:39 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (10.90 KB, patch)
2012-07-06 09:43 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-07-05 17:45:12 PDT
Created attachment 151004 [details] Patch
WebKit Review Bot
Comment 2 2012-07-05 17:47:16 PDT
Attachment 151004 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2012-07-05 17:47:25 PDT
Created attachment 151005 [details] Patch
WebKit Review Bot
Comment 4 2012-07-05 18:27:34 PDT
Comment on attachment 151005 [details] Patch Attachment 151005 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13151209 New failing tests: fast/block/float/previous-sibling-float-002.html
WebKit Review Bot
Comment 5 2012-07-05 18:27:37 PDT
Created attachment 151009 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Dave Hyatt
Comment 6 2012-07-06 09:39:55 PDT
Created attachment 151092 [details] Patch
Dave Hyatt
Comment 7 2012-07-06 09:43:23 PDT
Created attachment 151094 [details] Patch
Andy Estes
Comment 8 2012-07-11 17:41:51 PDT
Looks like hyatt landed this: <http://trac.webkit.org/changeset/122244>
Andy Estes
Comment 9 2012-07-11 17:45:20 PDT
It also looks like this change broke Bing Maps. I filed <https://bugs.webkit.org/show_bug.cgi?id=91036>.
WebKit Review Bot
Comment 10 2012-07-27 05:01:42 PDT
Comment on attachment 151005 [details] Patch Cleared Simon Fraser's review+ from obsolete attachment 151005 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Ahmad Saleem
Comment 11 2023-11-10 06:33:25 PST
It seems this landed: https://github.com/WebKit/WebKit/commit/4bea3befee2820ad81a0a464c17b8cf604455c05 and then had regression, which is in 'Blocks' but it was marked duplicate of bug 91000, which was fixed properly rather than backing out this change. as follow: https://github.com/WebKit/WebKit/commit/8b8e24f4cc82da16952d735b23264ecfa6d995da Marking this as 'RESOLVED FIXED'.
Radar WebKit Bug Importer
Comment 12 2023-11-10 06:34:13 PST
<rdar://problem/118233130>
Note You need to log in before you can comment on or make changes to this bug.