Bug 90646

Summary: Improve the logical top estimation algorithm to be right more often
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: NEW ---    
Severity: Normal CC: aestes, dglazkov, eae, eric, jchaffraix, jkp2k, psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91036    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-05
none
Patch
none
Patch simon.fraser: review+

Description Dave Hyatt 2012-07-05 17:43:00 PDT
Improve the logical top estimation algorithm to be right more often. In particular we want to handle the basic case of <body><h1> or <body><p>.
Comment 1 Dave Hyatt 2012-07-05 17:45:12 PDT
Created attachment 151004 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-05 17:47:16 PDT
Attachment 151004 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2012-07-05 17:47:25 PDT
Created attachment 151005 [details]
Patch
Comment 4 WebKit Review Bot 2012-07-05 18:27:34 PDT
Comment on attachment 151005 [details]
Patch

Attachment 151005 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13151209

New failing tests:
fast/block/float/previous-sibling-float-002.html
Comment 5 WebKit Review Bot 2012-07-05 18:27:37 PDT
Created attachment 151009 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Dave Hyatt 2012-07-06 09:39:55 PDT
Created attachment 151092 [details]
Patch
Comment 7 Dave Hyatt 2012-07-06 09:43:23 PDT
Created attachment 151094 [details]
Patch
Comment 8 Andy Estes 2012-07-11 17:41:51 PDT
Looks like hyatt landed this: <http://trac.webkit.org/changeset/122244>
Comment 9 Andy Estes 2012-07-11 17:45:20 PDT
It also looks like this change broke Bing Maps. I filed <https://bugs.webkit.org/show_bug.cgi?id=91036>.
Comment 10 WebKit Review Bot 2012-07-27 05:01:42 PDT
Comment on attachment 151005 [details]
Patch

Cleared Simon Fraser's review+ from obsolete attachment 151005 [details] so that this bug does not appear in http://webkit.org/pending-commit.