Bug 90642

Summary: Web Inspector: CodeGeneratorInspector.py: fix output write logic to support incremental build
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, rniwa, scottmg, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 91424    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Add missing close none

Peter Rybin
Reported 2012-07-05 16:28:12 PDT
Currently CodeGeneratorInspector.py always overwrites all output files. This triggers a cascade of recompilations. Only write output, if it actually changed.
Attachments
Patch (3.28 KB, patch)
2012-07-05 16:32 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Add missing close (3.50 KB, patch)
2012-07-17 12:49 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-07-05 16:32:22 PDT
Created attachment 151003 [details] Patch
Yury Semikhatsky
Comment 2 2012-07-05 23:25:12 PDT
Comment on attachment 151003 [details] Patch Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change.
Peter Rybin
Comment 3 2012-07-16 10:21:16 PDT
(In reply to comment #2) > (From update of attachment 151003 [details]) > Do you have numbers that would show how much time it saves? The generator shouldn't be called unless Inspector.json(which is relatively rare event) has changed in which case at least some output files should also change. I don't have numbers, but every time I develop code generator or do something related, I have to wait 1 extra minute per build, because incremental build doesn't work.
WebKit Review Bot
Comment 4 2012-07-16 11:11:09 PDT
Comment on attachment 151003 [details] Patch Clearing flags on attachment: 151003 Committed r122739: <http://trac.webkit.org/changeset/122739>
WebKit Review Bot
Comment 5 2012-07-16 11:11:16 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6 2012-07-16 13:15:56 PDT
It appears that this patch broke Mac builds: http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio
Peter Rybin
Comment 7 2012-07-16 14:26:01 PDT
(In reply to comment #6) > It appears that this patch broke Mac builds: > http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/536/steps/compile-webkit/logs/stdio I'm sorry to hear it. Our office opens in about 11 hours from now. If you need so, please feel free to roll the change back.
WebKit Review Bot
Comment 8 2012-07-16 14:29:32 PDT
Re-opened since this is blocked by 91424
Peter Rybin
Comment 9 2012-07-17 12:49:05 PDT
Created attachment 152808 [details] Add missing close
WebKit Review Bot
Comment 10 2012-07-19 04:50:26 PDT
Comment on attachment 152808 [details] Add missing close Clearing flags on attachment: 152808 Committed r123091: <http://trac.webkit.org/changeset/123091>
WebKit Review Bot
Comment 11 2012-07-19 04:50:33 PDT
All reviewed patches have been landed. Closing bug.
Scott Graham
Comment 12 2012-07-19 15:47:12 PDT
If this is relanded, could you please remove the print " writing " ...? Thanks.
Peter Rybin
Comment 13 2012-07-19 16:22:45 PDT
(In reply to comment #12) > If this is relanded, could you please remove the print " writing " ...? Thanks. https://bugs.webkit.org/show_bug.cgi?id=91758
Note You need to log in before you can comment on or make changes to this bug.