Bug 90602

Summary: [EFL][CMake] Move gtest sources to an upper level
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: cshu, dbates, gyuyoung.kim, k.czech, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90451, 90606, 90671    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Thiago Marcos P. Santos 2012-07-05 05:09:11 PDT 
So it can be shared by the API tests for EFL WK1 and WK2.
Comment 1 Thiago Marcos P. Santos 2012-07-05 10:34:07 PDT 
Created attachment 150957 [details]
Patch
Comment 2 Ryuan Choi 2012-07-05 18:19:37 PDT 
Comment on attachment 150957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150957&action=review

> Source/WebKit/PlatformEfl.cmake:297
>                      ${THIRDPARTY_DIR}/gtest/include

I think that we can ${THIRDPARTY_DIR}/gtest ?
Comment 3 Thiago Marcos P. Santos 2012-07-06 01:16:06 PDT 
Created attachment 151032 [details]
Patch

Thanks for having a look. The unused include path was removed.
Comment 4 Gyuyoung Kim 2012-07-06 01:20:57 PDT 
Comment on attachment 151032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151032&action=review

> Source/cmake/gtest/CMakeLists.txt:18
> +    ${GTEST_SOURCES}/gtest-filepath.cc

If possible, is this better to put by alphabetical order in this time ?
Comment 5 Thiago Marcos P. Santos 2012-07-06 02:07:11 PDT 
Created attachment 151040 [details]
Patch

Alpha sorted.
Comment 6 Thiago Marcos P. Santos 2012-07-06 03:34:57 PDT 
Created attachment 151048 [details]
Patch

Fixed indentation nit.
Comment 7 WebKit Review Bot 2012-07-06 12:20:01 PDT 
Comment on attachment 151048 [details]
Patch

Clearing flags on attachment: 151048

Committed r121990: <http://trac.webkit.org/changeset/121990>
Comment 8 WebKit Review Bot 2012-07-06 12:20:06 PDT 
All reviewed patches have been landed.  Closing bug.