Bug 90591

Summary: [BlackBerry] Make setForceDownload a setter method.
Product: WebKit Reporter: Mary Wu <mawu>
Component: PlatformAssignee: Mary Wu <mawu>
Status: RESOLVED FIXED    
Severity: Normal CC: leo.yang, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mary Wu
Reported 2012-07-05 01:28:21 PDT
A small typo fix in ResourceRequest.h
Attachments
Patch (1.66 KB, patch)
2012-07-05 01:35 PDT, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2012-07-08 21:07 PDT, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2012-07-05 01:35:10 PDT
Created attachment 150889 [details] Patch
Rob Buis
Comment 2 2012-07-05 07:03:23 PDT
Comment on attachment 150889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review Fix is good, explanation could be improved :) > Source/WebCore/ChangeLog:3 > + [BlackBerry] A small typo fix in ResourceRequest.h The bug title is not correct, this is not a typo! > Source/WebCore/ChangeLog:7 > + You could add something like "Make setForceDownload a setter method." Also, is this API used yet? If so, you could indicate which current use-case it fixes.
Mary Wu
Comment 3 2012-07-08 20:43:36 PDT
(In reply to comment #2) > (From update of attachment 150889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review > > Fix is good, explanation could be improved :) > > > Source/WebCore/ChangeLog:3 > > + [BlackBerry] A small typo fix in ResourceRequest.h > > The bug title is not correct, this is not a typo! Thanks, I will change the title. > > Source/WebCore/ChangeLog:7 > > + > > You could add something like "Make setForceDownload a setter method." > > Also, is this API used yet? If so, you could indicate which current use-case it fixes. Right now the API was only used for true case...To "Make setForceDownload a setter method", we should either use the parameter or remove parameter from the API. I take the first.
Mary Wu
Comment 4 2012-07-08 21:07:56 PDT
Created attachment 151178 [details] Patch
WebKit Review Bot
Comment 5 2012-07-08 21:56:55 PDT
Comment on attachment 151178 [details] Patch Clearing flags on attachment: 151178 Committed r122086: <http://trac.webkit.org/changeset/122086>
WebKit Review Bot
Comment 6 2012-07-08 21:57:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.