Summary: | workers should be in Modules/workers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | abarth, dglazkov, japhet, jochen, levin+threading, ojan, rakuco, vestbo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 79327 | ||||||
Attachments: |
|
Description
Gyuyoung Kim
2012-07-04 20:07:17 PDT
Created attachment 150863 [details]
Patch for EFL, GTK and QT.
This patch is working in progress.
Attachment 150863 [details] did not pass style-queue:
Source/WebCore/Modules/workers/SharedWorkerContext.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerLoaderProxy.h:47: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerContextProxy.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerContextProxy.h:51: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/Modules/workers/SharedWorker.cpp:85: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/Modules/workers/WorkerThread.cpp:72: More than one command on the same line [whitespace/newline] [4]
Source/WebCore/Modules/workers/WorkerScriptLoader.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/Worker.cpp:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/workers/Worker.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/DedicatedWorkerContext.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/DedicatedWorkerContext.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/workers/WorkerMessagingProxy.h:45: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerMessagingProxy.h:50: More than one command on the same line [whitespace/newline] [4]
Source/WebCore/Modules/workers/WorkerReportingProxy.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerReportingProxy.h:44: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/Modules/workers/DefaultSharedWorkerRepository.h:48: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/DefaultSharedWorkerRepository.h:59: More than one command on the same line [whitespace/newline] [4]
Source/WebCore/Modules/workers/SharedWorkerThread.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerRunLoop.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerRunLoop.h:71: More than one command on the same line [whitespace/newline] [4]
Source/WebCore/Modules/workers/WorkerRunLoop.h:73: The parameter name "task" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/workers/WorkerRunLoop.h:79: The parameter name "task" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/workers/WorkerRunLoop.cpp:35: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/Modules/workers/WorkerRunLoop.cpp:39: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/Modules/workers/WorkerRunLoop.cpp:160: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/workers/WorkerMessagingProxy.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/workers/SharedWorker.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerThread.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerScriptLoaderClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/DedicatedWorkerThread.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerLocation.h:40: Code inside a namespace sFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
hould not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/WorkerContext.h:49: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/DefaultSharedWorkerRepository.cpp:77: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/workers/WorkerObjectProxy.h:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/workers/WorkerObjectProxy.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/SharedWorkerRepository.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/AbstractWorker.h:47: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/Modules/workers/AbstractWorker.h:66: The parameter name "ec" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 38 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 150863 [details] Patch for EFL, GTK and QT. Attachment 150863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13141038 Comment on attachment 150863 [details] Patch for EFL, GTK and QT. Attachment 150863 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13136896 Comment on attachment 150863 [details]
Patch for EFL, GTK and QT.
As discussed on Feb 28 on webkit-dev, workers are a hub, not a spoke, in WebCore and therefore should not be moved into Modules.
(In reply to comment #5) > (From update of attachment 150863 [details]) > As discussed on Feb 28 on webkit-dev, workers are a hub, not a spoke, in WebCore and therefore should not be moved into Modules. I'm sorry. I should have checked it first. BTW, could you review Bug 82121? |