Bug 90564

Summary: Skip CSP 1.1 tests on ports where it's disabled.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89577, 89750    
Attachments:
Description Flags
Patch none

Description Mike West 2012-07-04 09:22:46 PDT 
ENABLE_CSP_NEXT is only running on the Chromium port. Before landing any features, we'll need to disable tests on those ports that don't have the flag turned on.
Comment 1 Mike West 2012-07-04 09:40:29 PDT 
Created attachment 150817 [details]
Patch
Comment 2 Adam Barth 2012-07-04 20:59:51 PDT 
gtk?
Comment 3 Mike West 2012-07-04 21:05:10 PDT 
(In reply to comment #2)
> gtk?

Arg. Missed it. Can you CQ- this patch and I'll upload another?

Also: aren't you on holiday? :)
Comment 4 WebKit Review Bot 2012-07-04 21:05:12 PDT 
Comment on attachment 150817 [details]
Patch

Clearing flags on attachment: 150817

Committed r121879: <http://trac.webkit.org/changeset/121879>
Comment 5 WebKit Review Bot 2012-07-04 21:05:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2012-07-04 21:09:06 PDT 
> Arg. Missed it. Can you CQ- this patch and I'll upload another?

Sorry, I didn't click it fast enough.  You should feel free to set the commit-queue- flag yourself.  :)

> Also: aren't you on holiday? :)

Yes, but I'm bored in my hotel room.  :)