Bug 90539

Summary: The HTML5 formtarget/formaction/formenctyp/formmethod/formnovalidate attributes don't work in button tags with nested elements
Product: WebKit Reporter: Martí Congost <marti.congost>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: forms-bugs, jaepark, japhet, ksakamoto, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Test case for this issue.
none
Patch
none
Patch 2 none

Description Martí Congost 2012-07-04 03:48:59 PDT
Created attachment 150762 [details]
Test case for this issue.

When clicking a button with a 'formtarget' attribute, the value of the attribute is not honored if the target of the click event is an element nested within the button, instead the button itself.

I've attached a small test case for this issue, which I have reproduced on Chromium/Chrome on both Linux and Windows.
Comment 1 Kunihiko Sakamoto 2012-10-16 22:06:05 PDT
Created attachment 169087 [details]
Patch
Comment 2 Kent Tamura 2012-10-16 22:25:50 PDT
Comment on attachment 169087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169087&action=review

> LayoutTests/fast/forms/formaction-attribute.html:-16
> -var doneAction2 = false;

Why did you remove this?
You should mention a reason for such unclear changes in the ChangeLog entry.
Comment 3 Kunihiko Sakamoto 2012-10-16 22:45:21 PDT
Created attachment 169092 [details]
Patch 2
Comment 4 Kunihiko Sakamoto 2012-10-16 22:46:46 PDT
Comment on attachment 169087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169087&action=review

>> LayoutTests/fast/forms/formaction-attribute.html:-16
>> -var doneAction2 = false;
> 
> Why did you remove this?
> You should mention a reason for such unclear changes in the ChangeLog entry.

Because this variable is not used.
Updated the ChangeLog entry in Patch 2.
Comment 5 Kent Tamura 2012-10-16 23:45:24 PDT
Comment on attachment 169092 [details]
Patch 2

ok
Comment 6 WebKit Review Bot 2012-10-17 00:06:45 PDT
Comment on attachment 169092 [details]
Patch 2

Clearing flags on attachment: 169092

Committed r131555: <http://trac.webkit.org/changeset/131555>
Comment 7 WebKit Review Bot 2012-10-17 00:06:51 PDT
All reviewed patches have been landed.  Closing bug.