| Summary: | XHR.send should support ArrayBufferView | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||||||
| Component: | WebCore Misc. | Assignee: | Kinuko Yasuda <kinuko> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, haraken, japhet, jochen, kbr, ojan, webkit.review.bot, yutak | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 85961 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kinuko Yasuda
2012-07-04 02:42:42 PDT
Created attachment 150748 [details]
Patch
Comment on attachment 150748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150748&action=review Looks good overall. A couple of minor comments which you can fix upon landing. r=me > Source/WebCore/xml/XMLHttpRequest.cpp:661 > + HistogramSupport::histogramEnumeration("WebCore.XHR.send.ArrayBufferView", XMLHttpRequestSendArrayBuffer, XMLHttpRequestSendArrayBufferEnumMax); The naming of this histogram is a little confusing. Consider naming it something like send.ArrayBufferOrView, here and below. > Source/WebCore/xml/XMLHttpRequest.cpp:686 > + } This code is essentially duplicated; please consider factoring it and the body of send(ArrayBuffer, ...) into a helper method taking (void*, unsigned) as arguments. Created attachment 151025 [details]
for submit
Created attachment 151027 [details]
for submit (fixed histogram name)
Comment on attachment 151027 [details]
for submit (fixed histogram name)
Looks good. r=me (even though this one wasn't marked r?)
Comment on attachment 151027 [details] for submit (fixed histogram name) Clearing flags on attachment: 151027 Committed r122074: <http://trac.webkit.org/changeset/122074> Seems like we can close this bug as resolved. |