| Summary: | Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||
| Component: | WebCore Misc. | Assignee: | Kinuko Yasuda <kinuko> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, haraken, japhet, jianli, jochen, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kinuko Yasuda
2012-07-04 02:36:04 PDT
Created attachment 150745 [details]
Patch
Comment on attachment 150745 [details]
Patch
OK.
Comment on attachment 150745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150745&action=review > Source/WebCore/fileapi/WebKitBlobBuilder.h:49 > + BlobConstructionReasonMax, This Max isn't needed. But I expect (hope?) that this code won't be aroudn very long anyway. Comment on attachment 150745 [details] Patch Rejecting attachment 150745 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: k #1 succeeded at 138 (offset -1 lines). patching file Source/WebCore/fileapi/WebKitBlobBuilder.cpp Hunk #1 FAILED at 35. Hunk #2 succeeded at 158 with fuzz 1 (offset 17 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/fileapi/WebKitBlobBuilder.cpp.rej patching file Source/WebCore/fileapi/WebKitBlobBuilder.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13476764 Committed r125386: <http://trac.webkit.org/changeset/125386> |