Bug 90503

Summary: nrwt: clean up exception handling and make sure we log some more failures
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch ojan: review+

Description Dirk Pranke 2012-07-03 15:44:39 PDT
nrwt: clean up exception handling and make sure we log some more failures
Comment 1 Dirk Pranke 2012-07-03 15:46:42 PDT
Created attachment 150683 [details]
Comment 2 WebKit Review Bot 2012-07-03 15:48:56 PDT
Attachment 150683 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:415:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ojan Vafai 2012-07-03 16:14:42 PDT
Comment on attachment 150683 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=150683&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:120
> +                # happenss (and log the appropriate messages).


> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:198
> +        driver = self._driver
> +        self._driver = None
> +        if driver:
>              _log.debug("%s killing driver" % self._name)
> -            self._driver.stop()
> -            self._driver = None
> +            driver.stop()

We don't need to worry about thread-safety, right? In that case, couldn't you just move the self._drive = None line to being right after the if statement? Then you wouldn't need the local variable. Not a big deal, just a little easier to read.
Comment 4 Dirk Pranke 2012-07-03 17:15:26 PDT
Committed r121816: <http://trac.webkit.org/changeset/121816>