Bug 90488
| Summary: | Inspector tests are slow | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | achicu, adamk, burg, dominicc, kbr, loislo, pfeldman, toyoshim |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tony Chang
This was noticed when we switched from test shell to DRT in chromium. There might be an unnecessary slowness in DRT (maybe we can cache the inspector?) or some other low hanging fruit.
All inspector tests are currently marked as slow in LayoutTests/platform/chromium/TestExpectations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexandru Chiculita
It's not slow, it's just not loading at all because it tries to load the devtools.html from the wrong place.
On my machine it tries the following url, but the inspector is not there. Copying it from src/out/Release/resources seems to fix the issue.
src/out/Release/DumpRenderTree.app/Contents/MacOS/resources/inspector/devtools.html
Tony Chang
(In reply to comment #1)
> src/out/Release/DumpRenderTree.app/Contents/MacOS/resources/inspector/devtools.html
We don't currently run inspector tests on Chromium Mac. Search for BUGCR89357 in TestExpectations.
Takashi Toyoshima
FYI, database-structure.html starts to crash recently.
I filed another bug; https://bugs.webkit.org/show_bug.cgi?id=93225
Kenneth Russell
Seeing http/tests/inspector/network-preflight-options.html start to time out on Windows Release as well. See:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Finspector%2Fnetwork-preflight-options.html
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/16909
Marking this test slow in Release mode in TestExpectations as well.
Kenneth Russell
Committed r126049: <http://trac.webkit.org/changeset/126049>
Adam Klein
Another single test that always times out in Win/Mac debug: inspector/styles/styles-computed-trace.html.
http://trac.webkit.org/changeset/137156 tried to remove the expectations entirely, and succeeded on Linux (test now passes in about 30s on Linux debug), but it still always times out on Win/Mac, so I re-added those expectations in http://trac.webkit.org/changeset/137174.
Dominic Cooney
Also inspector/extensions/extensions-reload.html is flakily slow on Win Release:
<http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fextensions%2Fextensions-reload.html>
Added expectations in r139820.
Dominic Cooney
Retitling this because a couple of Win release tests are discussed here.