Bug 90479 – [EFL][WK2] Ewk_View should report load errors

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

The Ewk_View should emit a "load,error" signal if the main frame fails loading.

[Chris Dumez]

Created attachment 150647 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 150647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150647&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:108
> +Eina_Bool ewk_web_error_cancellation_get(const Ewk_Web_Error* error)

is_cancellation_get ? or maybe just is_cancellation

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:51
> + * Query domain for this error.

That makes it quite hard for people to understand what this can actually represent; what kind of values etc. It is extensible true, but maybe an enum would fit better

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:74
> +EAPI const char *ewk_web_error_url_get(const Ewk_Web_Error *error);

IS that the originating url? Maybe add comment

> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:81
> + * @return the error code.

error code for domain?

[Chris Dumez]

Comment on attachment 150647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150647&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp:108
>> +Eina_Bool ewk_web_error_cancellation_get(const Ewk_Web_Error* error)
> 
> is_cancellation_get ? or maybe just is_cancellation

I'm not saying this looks great but I did it this way to follow the EFL API style. To name a few:
Eina_Bool evas_object_visible_get (const Evas_Object *obj);
Eina_Bool evas_object_focus_get (const Evas_Object *obj);
Eina_Bool evas_object_anti_alias_get (const Evas_Object *obj);

>> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:51
>> + * Query domain for this error.
> 
> That makes it quite hard for people to understand what this can actually represent; what kind of values etc. It is extensible true, but maybe an enum would fit better

Agreed. I'll look into it.

>> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:74
>> +EAPI const char *ewk_web_error_url_get(const Ewk_Web_Error *error);
> 
> IS that the originating url? Maybe add comment

Ok.

>> Source/WebKit2/UIProcess/API/efl/ewk_web_error.h:81
>> + * @return the error code.
> 
> error code for domain?

I'll use "HTTP error code" if it is alright.

[Chris Dumez]

Created attachment 150719 [details]
Patch

Take Kenneth's feedback into consideration.

[Chris Dumez]

Created attachment 150720 [details]
Patch

Rebase on master.

[WebKit Review Bot]

Comment on attachment 150720 [details]
Patch

Clearing flags on attachment: 150720

Committed r121835: <http://trac.webkit.org/changeset/121835>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.