Bug 90474

Summary: IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84217    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Joshua Bell 2012-07-03 10:35:34 PDT 
IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
Comment 1 Joshua Bell 2012-07-03 10:36:00 PDT 
Created attachment 150640 [details]
Patch
Comment 2 Joshua Bell 2012-07-03 18:42:17 PDT 
Comment on attachment 150640 [details]
Patch

Whoops, got uploaded with no changelog.
Comment 3 Joshua Bell 2012-07-09 10:12:44 PDT 
Created attachment 151266 [details]
Patch
Comment 4 Joshua Bell 2012-07-09 10:15:33 PDT 
alecflett@, dgrogan@ - please take a look.
Comment 5 David Grogan 2012-07-09 14:03:00 PDT 
Comment on attachment 151266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151266&action=review

LGTM

> LayoutTests/storage/indexeddb/resources/transaction-basics.js:289
> +    debug("Test that null and undefined are treated as strings");

Could you add a couple of evalAndExpectException lines in here for transaction = db.transaction(null/undefined)?
Comment 6 Joshua Bell 2012-07-09 16:26:30 PDT 
Created attachment 151348 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-07-09 17:48:26 PDT 
Comment on attachment 151348 [details]
Patch for landing

Clearing flags on attachment: 151348

Committed r122173: <http://trac.webkit.org/changeset/122173>
Comment 8 WebKit Review Bot 2012-07-09 17:48:31 PDT 
All reviewed patches have been landed.  Closing bug.