Bug 90447

Summary: Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Dongseong Hwang 2012-07-03 04:33:00 PDT
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.

Other sub-Image classes explicitly specify virtual on the destructors.

> grep "~.*Image(" `find -name "*.h"`
./graphics/BitmapImage.h:    ~BitmapImage();
./graphics/qt/StillImageQt.h:        ~StillImage();
./graphics/chromium/LayerTextureSubImage.h:    ~LayerTextureSubImage();  <- not implement Image
./graphics/GeneratorGeneratedImage.h:    virtual ~GeneratorGeneratedImage()
./graphics/Image.h:    virtual ~Image();
./graphics/cg/PDFDocumentImage.h:        virtual ~PDFDocumentImage();
Comment 1 Dongseong Hwang 2012-07-03 04:34:50 PDT
Created attachment 150581 [details]
patch
Comment 2 WebKit Review Bot 2012-07-04 23:54:16 PDT
Comment on attachment 150581 [details]
patch

Clearing flags on attachment: 150581

Committed r121884: <http://trac.webkit.org/changeset/121884>
Comment 3 WebKit Review Bot 2012-07-04 23:54:20 PDT
All reviewed patches have been landed.  Closing bug.