Bug 90447

Summary: Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Dongseong Hwang
Reported 2012-07-03 04:33:00 PDT
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual. Other sub-Image classes explicitly specify virtual on the destructors. > grep "~.*Image(" `find -name "*.h"` ./graphics/BitmapImage.h: ~BitmapImage(); ./graphics/qt/StillImageQt.h: ~StillImage(); ./graphics/chromium/LayerTextureSubImage.h: ~LayerTextureSubImage(); <- not implement Image ./graphics/GeneratorGeneratedImage.h: virtual ~GeneratorGeneratedImage() ./graphics/Image.h: virtual ~Image(); ./graphics/cg/PDFDocumentImage.h: virtual ~PDFDocumentImage();
Attachments
patch (2.32 KB, patch)
2012-07-03 04:34 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-07-03 04:34:50 PDT
Created attachment 150581 [details] patch
WebKit Review Bot
Comment 2 2012-07-04 23:54:16 PDT
Comment on attachment 150581 [details] patch Clearing flags on attachment: 150581 Committed r121884: <http://trac.webkit.org/changeset/121884>
WebKit Review Bot
Comment 3 2012-07-04 23:54:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.