Bug 90444

Summary: Update unit test after r121724
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, galpeter, kadam, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 90413    
Attachments:
Description Flags
proposed patch
ossy: review+, ossy: commit-queue-
proposed fix none

Csaba Osztrogonác
Reported 2012-07-03 04:09:12 PDT
http://trac.webkit.org/changeset/121724 broke the following unittest: FAILURE: webkitpy.tool.servers.gardeningserver_unittest.GardeningServerTest.test_rebaseline_new_port -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 205, in test_rebaseline_new_port self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py", line 178, in _post_to_path OutputCapture().assert_outputs(self, handler.do_POST, expected_stderr=expected_stderr, expected_stdout=expected_stdout) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 94, in assert_outputs testcase.assertEqual(stderr_string, expected_stderr) AssertionError: 'MOCK run_command: [\'echo\', \'rebaseline-json\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n' != 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n'
Attachments
proposed patch (1.71 KB, patch)
2012-07-03 04:32 PDT, Ádám Kallai
ossy: review+
ossy: commit-queue-
proposed fix (1.76 KB, patch)
2012-07-03 04:40 PDT, Ádám Kallai
no flags
Peter Gal
Comment 1 2012-07-03 04:21:18 PDT
(In reply to comment #0) > http://trac.webkit.org/changeset/121724 broke the following unittest: > It seems the testcase wasn't updated after the renaming of the command.
Ádám Kallai
Comment 2 2012-07-03 04:32:24 PDT
Created attachment 150580 [details] proposed patch I have updated the unit test. Do you think the changelog is correct now?
Csaba Osztrogonác
Comment 3 2012-07-03 04:34:40 PDT
Comment on attachment 150580 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=150580&action=review LGTM, r=me with a little changelog fix. > Tools/ChangeLog:3 > + Update unit test after r121724. Could you include the URL of this bug?
Ádám Kallai
Comment 4 2012-07-03 04:40:14 PDT
Created attachment 150582 [details] proposed fix I fixed it.
Csaba Osztrogonác
Comment 5 2012-07-03 04:44:04 PDT
Comment on attachment 150582 [details] proposed fix r=me
WebKit Review Bot
Comment 6 2012-07-03 05:38:41 PDT
Comment on attachment 150582 [details] proposed fix Clearing flags on attachment: 150582 Committed r121759: <http://trac.webkit.org/changeset/121759>
WebKit Review Bot
Comment 7 2012-07-03 05:38:45 PDT
All reviewed patches have been landed. Closing bug.
Ojan Vafai
Comment 8 2012-07-03 10:21:48 PDT
Thanks for fixing this!
Note You need to log in before you can comment on or make changes to this bug.