Bug 90407

Summary:

DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it creates are not shouldGenerate()

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Filip Pizlo 2012-07-02 15:33:52 PDT

We already assert this in later phases.  But asserting sooner will make tracking bugs easier, not to mention that it makes the phase more self-documenting.

Comment 1 Filip Pizlo 2012-07-02 15:35:21 PDT

Created attachment 150484 [details]
the patch

Already reviewed in person by Mark.  Putting up for EWS while I run my own tests.

Comment 2 Filip Pizlo 2012-07-02 17:10:42 PDT

Landed in http://trac.webkit.org/changeset/121712