Bug 90379

Summary: [MICRODATA] Build failure in html/HTMLPropertiesCollection.h
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: arko, darin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90377    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-07-02 05:51:01 PDT
Turning on the MICRODATA flag causes the following build failure: In file included from /home/chris/Devel/WebKit/Source/WebCore/dom/NodeRareData.h:39:0, from /home/chris/Devel/WebKit/Source/WebCore/dom/ClassNodeList.cpp:34: /home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h: In member function ‘void WebCore::HTMLPropertiesCollection::<anonymous struct>::updatePropertyCache(WebCore::Element*, const WTF::AtomicString&)’: /home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private /home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:17: error: within this context /home/chris/Devel/WebKit/Source/WebCore/html/HTMLCollection.h:91:17: error: ‘static void WebCore::HTMLCollectionCacheBase::append(WebCore::HTMLCollectionCacheBase::NodeCacheMap&, const WTF::AtomicString&, WebCore::Element*)’ is private /home/chris/Devel/WebKit/Source/WebCore/html/HTMLPropertiesCollection.h:128:60: error: within this context make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/dom/ClassNodeList.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
Attachments
Patch (1.61 KB, patch)
2012-07-02 06:02 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2012-07-02 06:02:55 PDT
Arko Saha
Comment 2 2012-07-02 06:47:44 PDT
Changes looks good to me but I am not a reviewer.
WebKit Review Bot
Comment 3 2012-07-02 09:59:32 PDT
Comment on attachment 150408 [details] Patch Clearing flags on attachment: 150408 Committed r121689: <http://trac.webkit.org/changeset/121689>
WebKit Review Bot
Comment 4 2012-07-02 09:59:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.