Summary: | [EFL] Move jhbuild dependencies based on SVN to tarballs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> | ||||||
Component: | WebKit EFL | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, d-r, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, naginenis, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Thiago Marcos P. Santos
2012-07-02 05:32:08 PDT
I think this is the closest we have to a official EFL Git mirror: http://git.enlightenment.fr/ Enlightenment links to it: http://www.enlightenment.org/p.php?p=contribute Created attachment 159391 [details]
Patch
After applying this patch, update-webkitefl takes less than 1 sec on my machine after the first run. Gyuyoung, Raphael, and others. Could you please give your opinions and if possible try a clean build with this patch? Thanks! Comment on attachment 159391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159391&action=review Looks fine to me -- I had some trouble in the past with these gitweb/cgit servers generating tarballs with different checksums each time they were fetched, but it looks like this doesn't happen here. Can you please remove the harfbuzz changes before committing? > Tools/efl/jhbuild.modules:155 > - <autotools id="harfbuzz" autogen-sh="configure"> > - <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2" > - checkoutdir="harfbuzz-0.9.2" > - repo="freedesktop.org" > - hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558" > - md5sum="f1c1a2793b44b4d6613f58cc92caa366"> > - </branch> > - </autotools> > + <autotools id="harfbuzz" autogen-sh="configure"> > + <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2" > + checkoutdir="harfbuzz-0.9.2" > + repo="freedesktop.org" > + hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558" > + md5sum="f1c1a2793b44b4d6613f58cc92caa366"> > + </branch> > + </autotools> Looks unrelated. (In reply to comment #5) > (From update of attachment 159391 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159391&action=review > > Looks fine to me -- I had some trouble in the past with these gitweb/cgit servers generating tarballs with different checksums each time they were fetched, but it looks like this doesn't happen here. Can you please remove the harfbuzz changes before committing? > > > Tools/efl/jhbuild.modules:155 > > - <autotools id="harfbuzz" autogen-sh="configure"> > > - <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2" > > - checkoutdir="harfbuzz-0.9.2" > > - repo="freedesktop.org" > > - hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558" > > - md5sum="f1c1a2793b44b4d6613f58cc92caa366"> > > - </branch> > > - </autotools> > > + <autotools id="harfbuzz" autogen-sh="configure"> > > + <branch module="software/harfbuzz/release/harfbuzz-0.9.2.tar.bz2" version="0.9.2" > > + checkoutdir="harfbuzz-0.9.2" > > + repo="freedesktop.org" > > + hash="sha256:c9b581d6357a32043b84ec78179390b582448de790deb487dfdb90b632dc8558" > > + md5sum="f1c1a2793b44b4d6613f58cc92caa366"> > > + </branch> > > + </autotools> > > Looks unrelated. This is a known issue [1]. gzip stores the timestamp by default. That's why I'm taking the tar.bz2, that can produce stable snapshots. Gonna remove this indentation fix, should be done in another patch. [1] http://git.661346.n2.nabble.com/PATCH-supply-n-to-gzip-to-produce-identical-tarballs-td6258329.html Created attachment 159533 [details]
Patch
Comment on attachment 159533 [details] Patch Clearing flags on attachment: 159533 Committed r126104: <http://trac.webkit.org/changeset/126104> All reviewed patches have been landed. Closing bug. |