Bug 90370

Summary: [EFL] Rename NotificationPresenterEfl with NotificationClientEfl
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80488    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-08
none
Patch
webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-02 none

Description Gyuyoung Kim 2012-07-02 02:58:55 PDT
Bug 80488 renamed NotificationPresenter with NotificationClient. So, EFL port needs to adjust it as well.
Comment 1 Gyuyoung Kim 2012-07-02 03:01:59 PDT
Created attachment 150387 [details]
Patch
Comment 2 Chris Dumez 2012-07-02 04:04:29 PDT
Comment on attachment 150387 [details]
Patch

LGTM. Can we land this as an unreviewed build fix?
Comment 3 Csaba Osztrogon√°c 2012-07-02 04:08:08 PDT
Comment on attachment 150387 [details]
Patch

rs=me
Comment 4 Gyuyoung Kim 2012-07-02 04:19:38 PDT
(In reply to comment #2)
> (From update of attachment 150387 [details])
> LGTM. Can we land this as an unreviewed build fix?

If possible, it is better to get review. In addition, notification feature is not enabled on EFL port yet.
Comment 5 WebKit Review Bot 2012-07-02 04:33:54 PDT
Comment on attachment 150387 [details]
Patch

Attachment 150387 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13128144

New failing tests:
fast/loader/loadInProgress.html
Comment 6 WebKit Review Bot 2012-07-02 04:33:58 PDT
Created attachment 150398 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Gyuyoung Kim 2012-07-02 05:13:28 PDT
Created attachment 150401 [details]
Patch
Comment 8 Gyuyoung Kim 2012-07-02 05:16:35 PDT
(In reply to comment #6)
> Created an attachment (id=150398) [details]
> Archive of layout-test-results from gce-cr-linux-08
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

I think this patch is only for EFL port. So, I don't understand why this patch influences on chromium layout test. It looks chromium bot has some problems before.
Comment 9 WebKit Review Bot 2012-07-02 06:18:33 PDT
Comment on attachment 150401 [details]
Patch

Attachment 150401 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13125168

New failing tests:
fast/loader/loadInProgress.html
Comment 10 WebKit Review Bot 2012-07-02 06:18:40 PDT
Created attachment 150412 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Gyuyoung Kim 2012-07-02 08:23:01 PDT
This patch is landed.
http://trac.webkit.org/changeset/121679