| Summary: | [EFL] Rename NotificationPresenterEfl with NotificationClientEfl | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 80488 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Gyuyoung Kim
2012-07-02 02:58:55 PDT
Created attachment 150387 [details]
Patch
Comment on attachment 150387 [details]
Patch
LGTM. Can we land this as an unreviewed build fix?
Comment on attachment 150387 [details]
Patch
rs=me
(In reply to comment #2) > (From update of attachment 150387 [details]) > LGTM. Can we land this as an unreviewed build fix? If possible, it is better to get review. In addition, notification feature is not enabled on EFL port yet. Comment on attachment 150387 [details] Patch Attachment 150387 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13128144 New failing tests: fast/loader/loadInProgress.html Created attachment 150398 [details]
Archive of layout-test-results from gce-cr-linux-08
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 150401 [details]
Patch
(In reply to comment #6) > Created an attachment (id=150398) [details] > Archive of layout-test-results from gce-cr-linux-08 > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid I think this patch is only for EFL port. So, I don't understand why this patch influences on chromium layout test. It looks chromium bot has some problems before. Comment on attachment 150401 [details] Patch Attachment 150401 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13125168 New failing tests: fast/loader/loadInProgress.html Created attachment 150412 [details]
Archive of layout-test-results from gce-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
This patch is landed. http://trac.webkit.org/changeset/121679 |