Bug 90332 – [GTK] Need to bump libsoup requirements (for `soup_cookie_jar_get_cookie_list`)

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Priit Laes (IRC: plaes)]

Getting following error when trying to build master:

[snip]
Source/WebCore/platform/network/soup/CookieJarSoup.cpp: In function ‘void WebCore::setCookies(WebCore::Document*, const WebCore::KURL&, const WTF::String&)’:
Source/WebCore/platform/network/soup/CookieJarSoup.cpp:99:86: error: ‘soup_cookie_jar_get_cookie_list’ was not declared in this scope
Source/WebCore/platform/network/soup/CookieJarSoup.cpp:117:92: error: ‘soup_cookie_jar_add_cookie_with_first_party’ was not declared in this scope
[/snip]

[Priit Laes (IRC: plaes)]

Created attachment 150310 [details]
webkit-bump-libsoup-to-2-39-3.patch

[Gustavo Noronha (kov)]

Comment on attachment 150310 [details]
webkit-bump-libsoup-to-2-39-3.patch

Attachment 150310 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13110630

[Priit Laes (IRC: plaes)]

(In reply to comment #2)
> (From update of attachment 150310 [details])
> Attachment 150310 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/13110630

> checking for LIBSOUP... no
> configure: error: Package requirements (libsoup-2.4 >= 2.39.3) were not met:
> 
> Requested 'libsoup-2.4 >= 2.39.3' but version of libsoup is 2.39.2

soup_cookie_jar_add_cookie_with_first_party() was added in 2.39.3

[Priit Laes (IRC: plaes)]

Created attachment 150311 [details]
webkit-bump-libsoup-to-2-39-2.patch

[Chris Dumez]

Comment on attachment 150311 [details]
webkit-bump-libsoup-to-2-39-2.patch

LGTM. Sorry I forgot to do that.

[WebKit Review Bot]

Comment on attachment 150311 [details]
webkit-bump-libsoup-to-2-39-2.patch

Clearing flags on attachment: 150311

Committed r121772: <http://trac.webkit.org/changeset/121772>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.