Bug 90322

Summary: HTMLCollection's caches should be owned by either ElementRareData or Document
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cmarcelo, darin, kling, koivisto, mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89919    
Attachments:
Description Flags
Cleanup andersca: review+

Ryosuke Niwa
Reported 2012-06-29 16:02:58 PDT
Right now, multiple Element subclasses such as HTMLFormElement and HTMLSelectElement have their own OwnPtr of HTMLCollection. Since ElementRareData already has a cache entry for each collection type, we should be using that instead.
Attachments
Cleanup (23.79 KB, patch)
2012-06-29 16:11 PDT, Ryosuke Niwa 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-06-29 16:11:57 PDT
Created attachment 150268 [details] Cleanup
Ryosuke Niwa
Comment 2 2012-06-29 16:56:50 PDT
Committed r121603: <http://trac.webkit.org/changeset/121603>
Note You need to log in before you can comment on or make changes to this bug.