Summary: | Allow AudioDestination to support local/live audio input | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||
Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, ericbidelman, eric.carlson, feature-media-reviews, fishd, henrika, jamesr, kbr, pnormand, tkent+wkapi, webkit.review.bot, xingnan.wang | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Rogers
2012-06-29 15:47:01 PDT
Created attachment 150267 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. This change works with: https://bugs.webkit.org/show_bug.cgi?id=90110 In order to help implement MediaStreamAudioSourceNode This patch deals with the lower-level audio hardware aspects of getting local/live audio input. Comment on attachment 150267 [details]
Patch
API change LGTM
Comment on attachment 150267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review Looks good overall. Couple of minor bookkeeping questions. r=me > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326 > + // FIXME: Add support for local/live audio input. Is there a bug filed to track this work? > Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:158 > + // FIXME: Add support for local/live audio input. Same question. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:133 > + // FIXME: Add support for local/live audio input. Here too. Committed r124264: <http://trac.webkit.org/changeset/124264> (In reply to comment #5) > (From update of attachment 150267 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review > > Looks good overall. Couple of minor bookkeeping questions. r=me > > > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326 > > + // FIXME: Add support for local/live audio input. > > Is there a bug filed to track this work? > I'll try to take care of this one soon. |