Bug 90318

Summary: Allow AudioDestination to support local/live audio input
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, ericbidelman, eric.carlson, feature-media-reviews, fishd, henrika, jamesr, kbr, pnormand, tkent+wkapi, webkit.review.bot, xingnan.wang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Description Chris Rogers 2012-06-29 15:47:01 PDT
Allow AudioDestination to support local/live audio input
Comment 1 Chris Rogers 2012-06-29 16:03:57 PDT
Created attachment 150267 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-29 16:05:37 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Chris Rogers 2012-06-29 16:07:27 PDT
This change works with:
https://bugs.webkit.org/show_bug.cgi?id=90110

In order to help implement MediaStreamAudioSourceNode

This patch deals with the lower-level audio hardware aspects of getting local/live audio input.
Comment 4 Adam Barth 2012-06-29 18:22:55 PDT
Comment on attachment 150267 [details]
Patch

API change LGTM
Comment 5 Kenneth Russell 2012-07-31 14:18:27 PDT
Comment on attachment 150267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review

Looks good overall. Couple of minor bookkeeping questions. r=me

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326
> +    // FIXME: Add support for local/live audio input.

Is there a bug filed to track this work?

> Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:158
> +    // FIXME: Add support for local/live audio input.

Same question.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:133
> +    // FIXME: Add support for local/live audio input.

Here too.
Comment 6 Chris Rogers 2012-07-31 16:05:03 PDT
Committed r124264: <http://trac.webkit.org/changeset/124264>
Comment 7 Philippe Normand 2012-08-01 00:04:03 PDT
(In reply to comment #5)
> (From update of attachment 150267 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review
> 
> Looks good overall. Couple of minor bookkeeping questions. r=me
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326
> > +    // FIXME: Add support for local/live audio input.
> 
> Is there a bug filed to track this work?
> 

I'll try to take care of this one soon.