Bug 90302

Summary: Remove warning about protected values when the Heap is being destroyed
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2012-06-29 13:03:22 PDT
Having to do book-keeping about whether values allocated from a certain VM are or are not protected makes the JSC API much more difficult to use correctly. Clients should be able to throw an entire VM away and not have to worry about unprotecting all of the values that they protected earlier.
Attachments
Patch (1.68 KB, patch)
2012-06-29 13:12 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-06-29 13:12:45 PDT
Created attachment 150241 [details] Patch
Mark Hahnenberg
Comment 2 2012-06-29 13:15:13 PDT
<rdar://problem/11760002>
Geoffrey Garen
Comment 3 2012-06-29 13:46:45 PDT
Comment on attachment 150241 [details] Patch r=me
WebKit Review Bot
Comment 4 2012-06-29 18:14:25 PDT
Comment on attachment 150241 [details] Patch Clearing flags on attachment: 150241 Committed r121607: <http://trac.webkit.org/changeset/121607>
WebKit Review Bot
Comment 5 2012-06-29 18:14:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.