Bug 90299

Summary: Remove type from screenColorProfile API
Product: WebKit Reporter: Tony Payne <tpayne>
Component: New BugsAssignee: Tony Payne <tpayne>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, mifenton, noel.gordon, rakuco, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tony Payne
Reported 2012-06-29 11:31:06 PDT
Remove type from screenColorProfile API
Attachments
Patch (8.73 KB, patch)
2012-06-29 11:32 PDT, Tony Payne 		no flags
DetailsFormatted DiffDiff
Patch (8.73 KB, patch)
2012-06-29 11:37 PDT, Tony Payne 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Payne
Comment 1 2012-06-29 11:32:33 PDT
Created attachment 150223 [details] Patch
WebKit Review Bot
Comment 2 2012-06-29 11:35:41 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-06-29 11:36:05 PDT
Attachment 150223 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Payne
Comment 4 2012-06-29 11:37:49 PDT
Created attachment 150227 [details] Patch
Adam Barth
Comment 5 2012-06-29 13:56:21 PDT
Comment on attachment 150227 [details] Patch Thanks.
WebKit Review Bot
Comment 6 2012-06-29 16:40:51 PDT
Comment on attachment 150227 [details] Patch Clearing flags on attachment: 150227 Committed r121600: <http://trac.webkit.org/changeset/121600>
WebKit Review Bot
Comment 7 2012-06-29 16:40:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.