| Summary: | [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||
| Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||
| Status: | RESOLVED DUPLICATE | ||||||||
| Severity: | Normal | CC: | abarth, gyuyoung.kim, kbalazs, kpiascik, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sudarsana Nagineni (babu)
2012-06-29 08:43:09 PDT
Created attachment 150192 [details]
Patch
Comment on attachment 150192 [details] Patch Clearing flags on attachment: 150192 Committed r121579: <http://trac.webkit.org/changeset/121579> All reviewed patches have been landed. Closing bug. Doesn't it mean that the patch is bad? If so, why don't we revert instead? Or maybe we just need to change some call sites in wk2 platform code? Here is the diff on Qt: -viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 +viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 Relevant parts of the test: <meta name="viewport" content="width=device-width"> layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534); So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites. Reopening to attach new patch. Created attachment 150329 [details]
Patch
> So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.
... but it turned it to an int division :)
I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286 But commit queue was being a little stupid so I'd need to re-submit. I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine. Comment on attachment 150329 [details] Patch Attachment 150329 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13113854 (In reply to comment #9) > I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286 But commit queue was being a little stupid so I'd need to re-submit. I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine. Well, my patch did not build on Windows, so instead I lent your patch - http://trac.webkit.org/changeset/121661. *** This bug has been marked as a duplicate of bug 90286 *** |