Bug 90287 – [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555

• Component: WebKit EFL
• Status: RESOLVED DUPLICATE

[Sudarsana Nagineni (babu)]

fast/viewport/viewport-91.html is failing after r121555 and should be skipped until bug 90286 is fixed.

[Sudarsana Nagineni (babu)]

Created attachment 150192 [details]
Patch

[WebKit Review Bot]

Comment on attachment 150192 [details]
Patch

Clearing flags on attachment: 150192

Committed r121579: <http://trac.webkit.org/changeset/121579>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Balazs Kelemen]

Doesn't it mean that the patch is bad? If so, why don't we revert instead? Or maybe we just need to change some call sites in wk2 platform code?

[Balazs Kelemen]

Here is the diff on Qt:

-viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000
+viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000

Relevant parts of the test:
<meta name="viewport" content="width=device-width">
layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534);

So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.

[Balazs Kelemen]

Reopening to attach new patch.

[Balazs Kelemen]

Created attachment 150329 [details]
Patch

[Balazs Kelemen]

> So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.

... but it turned it to an int division :)

[Konrad Piascik]

I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286  But commit queue was being a little stupid so I'd need to re-submit.  I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine.

[Build Bot]

Comment on attachment 150329 [details]
Patch

Attachment 150329 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13113854

[Balazs Kelemen]

(In reply to comment #9)
> I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286  But commit queue was being a little stupid so I'd need to re-submit.  I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine.

Well, my patch did not build on Windows, so instead I lent your patch - http://trac.webkit.org/changeset/121661.

*** This bug has been marked as a duplicate of bug 90286 ***