| Summary: | [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xiaobo Wang <xiaobwang> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | Normal | CC: | mifenton, mxie, rakuco, rwlbuis, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | Other | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Xiaobo Wang
2012-06-29 04:33:24 PDT
RIM PR #154707 Created attachment 150149 [details]
Git patch
Comment on attachment 150149 [details] Git patch View in context: https://bugs.webkit.org/attachment.cgi?id=150149&action=review Looks good. > Source/WebKit/PlatformBlackBerry.cmake:27 > +IF ( NOT PUBLIC_BUILD) Space character not needed. Created attachment 150153 [details]
Git patch
Removed a unneeded space.
Comment on attachment 150153 [details]
Git patch
Looks good.
Comment on attachment 150153 [details] Git patch Rejecting attachment 150153 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 144734. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13120287 (In reply to comment #6) > (From update of attachment 150153 [details]) > Rejecting attachment 150153 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > 48>At revision 144734. > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/13120287 Oops, needs removal of OOPS. (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 150153 [details] [details]) > > Rejecting attachment 150153 [details] [details] from commit-queue. > > > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > > > Last 500 characters of output: > > webkit-commit-queue/Source/WebKit/chromium/webkit --revision 144734 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > 48>At revision 144734. > > > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > Updating webkit projects from gyp files... > > > > Full output: http://queues.webkit.org/results/13120287 > > Oops, needs removal of OOPS. More specifically, in Tools/ChangeLog the Reviewed by line is duplicated. Created attachment 150355 [details]
Git patch
Removed redundant "Reviewed by NOBODY (OOPS!)." in Tools/ChangeLog.
Comment on attachment 150355 [details] Git patch Clearing flags on attachment: 150355 Committed r121725: <http://trac.webkit.org/changeset/121725> Comment on attachment 150149 [details] Git patch Cleared Rob Buis's review+ from obsolete attachment 150149 [details] so that this bug does not appear in http://webkit.org/pending-commit. The patch has landed, resolve as fixed. close it |