| Summary: | [Qt][WTR] Get rid of using DumpRenderTreeSupportQt | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | andersca, dglazkov, eric, gustavo, hausmann, morrita, ossy, philn, rakuco, xan.lopez, zoltan | ||||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Balazs Kelemen
2012-06-29 02:41:53 PDT
Created attachment 150134 [details]
Patch
Comment on attachment 150134 [details] Patch Clearing flags on attachment: 150134 Committed r121550: <http://trac.webkit.org/changeset/121550> All reviewed patches have been landed. Closing bug. Reverted in r121788. Need to fix some issues of the Qt build system before relanding this. *** Bug 90346 has been marked as a duplicate of this bug. *** Created attachment 154410 [details]
Patch
Comment on attachment 154410 [details] Patch Attachment 154410 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13342356 Comment on attachment 154410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154410&action=review I think the patch is good, I like this approach. But it appears to break the Gtk build, the EWS failure seems valid. > Source/WebCore/ChangeLog:3 > + [Qt][WTR] Get rid of using DumpRenderTreeSupportQt I think the title is a bit generic, what about renaming it to "Get rid of DumpRenderTreeSupportQt::injectInternals wrapper"? Created attachment 155747 [details]
Patch
Comment on attachment 155747 [details] Patch Attachment 155747 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13400755 Comment on attachment 155747 [details] Patch Attachment 155747 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13393977 Comment on attachment 155747 [details] Patch Attachment 155747 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13417118 Adding WEBCORE_TESTING to WebCoreTestSupport::injectInternalsObject and WebCoreTestSupport::resetInternalsObject breaks the win build. It needs the symbol "__declspec(dllimport) void __cdecl WebCoreTestSupport::injectInternalsObject(struct OpaqueJSContext const *)" in DRT but it doesn't find it. It seems strange to me because dllimport should be the right here to do from DRT. Idea? (In reply to comment #13) > Adding WEBCORE_TESTING to WebCoreTestSupport::injectInternalsObject and WebCoreTestSupport::resetInternalsObject breaks the win build. It needs the symbol "__declspec(dllimport) void __cdecl WebCoreTestSupport::injectInternalsObject(struct OpaqueJSContext const *)" in DRT but it doesn't find it. It seems strange to me because dllimport should be the right here to do from DRT. Idea? WEBCORE_TESTING isn't ready yet. I'm sorry for the inconvenience, (In reply to comment #14) > (In reply to comment #13) > > Adding WEBCORE_TESTING to WebCoreTestSupport::injectInternalsObject and WebCoreTestSupport::resetInternalsObject breaks the win build. It needs the symbol "__declspec(dllimport) void __cdecl WebCoreTestSupport::injectInternalsObject(struct OpaqueJSContext const *)" in DRT but it doesn't find it. It seems strange to me because dllimport should be the right here to do from DRT. Idea? > > WEBCORE_TESTING isn't ready yet. I'm sorry for the inconvenience, I'm a bit confused how to proceed with this. I don't want to add a new platform specific define because WEBCORE_TESTING is supposed to serve for this Could you describe what is missing and how could those symbols note become exported? I could not take care about this in the foreseeable future so feel free to pick it. |