Bug 90245

Summary: updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Simon Fraser (smfr)
Reported 2012-06-28 21:20:25 PDT
RenderLayer::styleChanged() has: #if USE(ACCELERATED_COMPOSITING) updateDescendantDependentFlags(); updateTransform(); Seems like both should be outside the #ifdef
Attachments
Patch (1.73 KB, patch)
2012-06-29 20:28 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-06-29 20:28:02 PDT
Created attachment 150298 [details] Patch
mitz
Comment 2 2012-06-29 20:31:18 PDT
Comment on attachment 150298 [details] Patch Do you have a test to prove this?
Simon Fraser (smfr)
Comment 3 2012-06-29 20:32:14 PDT
I do not; i just noticed this when looking at the code. I'm not sure any of the top tier platforms build with accelerated compositing off any more.
Simon Fraser (smfr)
Comment 4 2012-06-29 20:42:28 PDT
http://trac.webkit.org/changeset/121616
Note You need to log in before you can comment on or make changes to this bug.