Bug 90223

Summary: Update FIXME comment in XMLDocumentParser::wellFormed
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2012-06-28 16:22:20 PDT
XMLDocumentParser::wellFormed is still used by the XMLHttpRequest to check if the responseXML was well formed. So it can't be removed.
Attachments
Patch (1.60 KB, patch)
2012-06-28 16:24 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-06-28 16:24:54 PDT
Created attachment 150041 [details] Patch
Kwang Yul Seo
Comment 2 2012-06-28 23:33:44 PDT
BTW, it is weird to have wellFormed method in DecodedDataDocumentParser class because it is used only by the XMLDocumentParser.
Adam Barth
Comment 3 2012-06-29 07:42:39 PDT
Comment on attachment 150041 [details] Patch Thanks. Yeah, it's a bit odd to have in decoded document parser, but probably not problematic.
WebKit Review Bot
Comment 4 2012-06-29 08:27:59 PDT
Comment on attachment 150041 [details] Patch Clearing flags on attachment: 150041 Committed r121564: <http://trac.webkit.org/changeset/121564>
WebKit Review Bot
Comment 5 2012-06-29 08:28:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.