Bug 90216

Summary: Undo handling in WebKit2 is not robust against some page-closing code paths
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Major Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch that clears Undo actions when the WKView moves to another window (including the nil window) enrica: review+

John Sullivan
Reported 2012-06-28 15:55:40 PDT
This is in radar as <rdar://problem/11766518> PageClientImpl registers entries on the undo stack, but does not guarantee that all such entries will be removed from the undo stack before the PageClientImpl is dealloc'ed. This leads to some code paths in which a bad undo target can be left on the undo stack, leading to a crash when Undo is then performed.
Attachments
Patch that clears Undo actions when the WKView moves to another window (including the nil window) (2.73 KB, patch)
2012-06-28 16:03 PDT, John Sullivan 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2012-06-28 16:03:15 PDT
Created attachment 150034 [details] Patch that clears Undo actions when the WKView moves to another window (including the nil window)
Enrica Casucci
Comment 2 2012-06-28 16:12:05 PDT
Comment on attachment 150034 [details] Patch that clears Undo actions when the WKView moves to another window (including the nil window) Looks good to me
Alexey Proskuryakov
Comment 3 2013-03-16 22:38:02 PDT
This was committed in <http://trac.webkit.org/changeset/121482>.
Note You need to log in before you can comment on or make changes to this bug.