Bug 90215

Summary: [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, mrobinson, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tony Chang 2012-06-28 15:33:26 PDT 
[GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
Comment 1 Tony Chang 2012-06-28 15:34:20 PDT 
Created attachment 150026 [details]
Patch
Comment 2 Tony Chang 2012-06-28 15:36:46 PDT 
I ran:
  WEBKITOUTPUTDIR=/src/WebKit/gtkbuild build-webkit --gtk
which properly built everything into /src/WebKit/gtkbuild.  When I tried to run
  WEBKITOUTPUTDIR=/src/WebKit/gtkbuild new-run-webkit-tests --gtk
I get a crash because it's unable to find the test fonts.
Comment 3 Martin Robinson 2012-06-28 15:41:56 PDT 
Comment on attachment 150026 [details]
Patch

Great! Though this should probably also happen for WebKitTestRunner as well in Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp.
Comment 4 Tony Chang 2012-06-28 15:54:06 PDT 
Comment on attachment 150026 [details]
Patch

Oops, will fix WTR too.
Comment 5 Tony Chang 2012-06-28 16:05:45 PDT 
Created attachment 150037 [details]
Patch
Comment 6 Martin Robinson 2012-06-28 16:14:08 PDT 
Comment on attachment 150037 [details]
Patch

Thank you very much for fixing this. You are both an engineer and a gentleman.
Comment 7 WebKit Review Bot 2012-06-28 18:18:54 PDT 
Comment on attachment 150037 [details]
Patch

Clearing flags on attachment: 150037

Committed r121499: <http://trac.webkit.org/changeset/121499>
Comment 8 WebKit Review Bot 2012-06-28 18:18:59 PDT 
All reviewed patches have been landed.  Closing bug.