| Summary: | [Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, fishd, jamesr, japhet, leandrogracia, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 66687 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2012-06-28 14:34:24 PDT
Created attachment 150016 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. lgtm. Comment on attachment 150016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review > Source/WebKit/chromium/public/WebViewClient.h:375 > + virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); } detech -> detect? (In reply to comment #4) > (From update of attachment 150016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review > > > Source/WebKit/chromium/public/WebViewClient.h:375 > > + virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); } > > detech -> detect? Yep. Thanks! Created attachment 150028 [details]
Patch for landing
Comment on attachment 150028 [details] Patch for landing Clearing flags on attachment: 150028 Committed r121483: <http://trac.webkit.org/changeset/121483> All reviewed patches have been landed. Closing bug. |