Bug 90205

Summary:

run-bindings-tests should return non-zero exit code on test failure

Product:

WebKit

Reporter:

Joshua Bell <jsbell>

Component:

New Bugs

Assignee:

Joshua Bell <jsbell>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Joshua Bell 2012-06-28 14:11:54 PDT

run-bindings-tests should return non-zero exit code on test failure

Comment 1 Joshua Bell 2012-06-28 14:12:11 PDT

Created attachment 150012 [details]
Patch

Comment 2 Joshua Bell 2012-06-28 14:13:50 PDT

I wrap run-bindings-tests (and a bunch of other things) in a personal pre-upload check script, but it doesn't return an exit code on failure so I need to manually inspect the output.

Looks like a trivial change to return the exit code - any reason not to

Comment 3 Joshua Bell 2012-06-28 15:51:22 PDT

haraken@ or abarth@ - r? cq?

Comment 4 WebKit Review Bot 2012-06-28 17:48:07 PDT

Comment on attachment 150012 [details]
Patch

Clearing flags on attachment: 150012

Committed r121493: <http://trac.webkit.org/changeset/121493>

Comment 5 WebKit Review Bot 2012-06-28 17:48:11 PDT

All reviewed patches have been landed.  Closing bug.