Bug 90205 - run-bindings-tests should return non-zero exit code on test failure
Summary: run-bindings-tests should return non-zero exit code on test failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 14:11 PDT by Joshua Bell
Modified: 2012-06-28 17:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2012-06-28 14:12 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-06-28 14:11:54 PDT 
run-bindings-tests should return non-zero exit code on test failure
Comment 1 Joshua Bell 2012-06-28 14:12:11 PDT 
Created attachment 150012 [details]
Patch
Comment 2 Joshua Bell 2012-06-28 14:13:50 PDT 
I wrap run-bindings-tests (and a bunch of other things) in a personal pre-upload check script, but it doesn't return an exit code on failure so I need to manually inspect the output.

Looks like a trivial change to return the exit code - any reason not to
Comment 3 Joshua Bell 2012-06-28 15:51:22 PDT 
haraken@ or abarth@ - r? cq?
Comment 4 WebKit Review Bot 2012-06-28 17:48:07 PDT 
Comment on attachment 150012 [details]
Patch

Clearing flags on attachment: 150012

Committed r121493: <http://trac.webkit.org/changeset/121493>
Comment 5 WebKit Review Bot 2012-06-28 17:48:11 PDT 
All reviewed patches have been landed.  Closing bug.