RESOLVED FIXED 90205
run-bindings-tests should return non-zero exit code on test failure 
https://bugs.webkit.org/show_bug.cgi?id=90205
Summary run-bindings-tests should return non-zero exit code on test failure
Joshua Bell
Reported 2012-06-28 14:11:54 PDT
run-bindings-tests should return non-zero exit code on test failure
Attachments
Patch (1.15 KB, patch)
2012-06-28 14:12 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-06-28 14:12:11 PDT
Created attachment 150012 [details] Patch
Joshua Bell
Comment 2 2012-06-28 14:13:50 PDT
I wrap run-bindings-tests (and a bunch of other things) in a personal pre-upload check script, but it doesn't return an exit code on failure so I need to manually inspect the output. Looks like a trivial change to return the exit code - any reason not to
Joshua Bell
Comment 3 2012-06-28 15:51:22 PDT
haraken@ or abarth@ - r? cq?
WebKit Review Bot
Comment 4 2012-06-28 17:48:07 PDT
Comment on attachment 150012 [details] Patch Clearing flags on attachment: 150012 Committed r121493: <http://trac.webkit.org/changeset/121493>
WebKit Review Bot
Comment 5 2012-06-28 17:48:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.