Bug 90194

Summary:

[V8] NodeList wrappers are not kept alive as needed

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

New Bugs

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, jochen, ojan, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Erik Arvidsson 2012-06-28 11:55:16 PDT

[V8] NodeList wrappers are not kept alive as needed

Comment 1 Erik Arvidsson 2012-06-28 11:59:29 PDT

Created attachment 149982 [details]
Patch

Comment 2 Ojan Vafai 2012-06-28 12:08:10 PDT

Comment on attachment 149982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149982&action=review

> Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp:70
> +            v8::Persistent<v8::Object> ownerWrapper = store->domNodeMap().get(owner);
> +            if (!ownerWrapper.IsEmpty()) {

Does this over the case of getElementsByTagName? For that case, we probably don't want to add an implicit reference, right? Or does that actually always return the same object?

Comment 3 Erik Arvidsson 2012-06-28 14:35:42 PDT

Created attachment 150015 [details]
Patch

Comment 4 Erik Arvidsson 2012-06-28 14:37:27 PDT

This now tests all DynamicNodeLists (except MicroDataItemList because it is not built by default).

The V8 FAIL is due to 90208

Comment 5 Erik Arvidsson 2012-06-28 15:32:53 PDT

Created attachment 150025 [details]
Patch for landing

Comment 6 WebKit Review Bot 2012-06-28 18:14:03 PDT

Comment on attachment 150025 [details]
Patch for landing

Clearing flags on attachment: 150025

Committed r121496: <http://trac.webkit.org/changeset/121496>

Comment 7 WebKit Review Bot 2012-06-28 18:14:14 PDT

All reviewed patches have been landed.  Closing bug.