Bug 90194 - [V8] NodeList wrappers are not kept alive as needed
Summary: [V8] NodeList wrappers are not kept alive as needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 11:55 PDT by Erik Arvidsson
Modified: 2012-06-28 18:14 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.47 KB, patch)
2012-06-28 11:59 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (6.59 KB, patch)
2012-06-28 14:35 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch for landing (6.52 KB, patch)
2012-06-28 15:32 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-06-28 11:55:16 PDT
[V8] NodeList wrappers are not kept alive as needed
Comment 1 Erik Arvidsson 2012-06-28 11:59:29 PDT
Created attachment 149982 [details]
Patch
Comment 2 Ojan Vafai 2012-06-28 12:08:10 PDT
Comment on attachment 149982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149982&action=review

> Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp:70
> +            v8::Persistent<v8::Object> ownerWrapper = store->domNodeMap().get(owner);
> +            if (!ownerWrapper.IsEmpty()) {

Does this over the case of getElementsByTagName? For that case, we probably don't want to add an implicit reference, right? Or does that actually always return the same object?
Comment 3 Erik Arvidsson 2012-06-28 14:35:42 PDT
Created attachment 150015 [details]
Patch
Comment 4 Erik Arvidsson 2012-06-28 14:37:27 PDT
This now tests all DynamicNodeLists (except MicroDataItemList because it is not built by default).

The V8 FAIL is due to 90208
Comment 5 Erik Arvidsson 2012-06-28 15:32:53 PDT
Created attachment 150025 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-06-28 18:14:03 PDT
Comment on attachment 150025 [details]
Patch for landing

Clearing flags on attachment: 150025

Committed r121496: <http://trac.webkit.org/changeset/121496>
Comment 7 WebKit Review Bot 2012-06-28 18:14:14 PDT
All reviewed patches have been landed.  Closing bug.