Bug 90186 – Make rebaseline-test and rebseline-expectations work for non-Chromium ports

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

Make rebaseline-test and rebseline-expectations work for non-Chromium ports

[Ojan Vafai]

Created attachment 149968 [details]
Patch

[Simon Fraser (smfr)]

\o/

[Adam Barth]

Comment on attachment 149968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149968&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:84
> +        if port.name().startswith('chromium-'):

Should we have a way to ask the port whether it's a Chromium port rather than using string operations?

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:257
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None

What's up with the qmake calls?  Will this error out on systems that don't have qmake?

[Ojan Vafai]

Comment on attachment 149968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149968&action=review

>> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:84
>> +        if port.name().startswith('chromium-'):
> 
> Should we have a way to ask the port whether it's a Chromium port rather than using string operations?

Probably. I thought about this briefly, but didn't come up with a solution I loved. I'll put a FIXME.

>> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:257
>> +MOCK run_command: ['qmake', '-v'], cwd=None
> 
> What's up with the qmake calls?  Will this error out on systems that don't have qmake?

The Qt port class calls out to qmake to find out which qt version to use. It handles failures by just choosing a specific version, so it works fine on my system that lacks qmake. This should probably be fixed, but I'm not really sure what the right fix is.

[Ojan Vafai]

Committed r121447: <http://trac.webkit.org/changeset/121447>