Bug 90114

Summary: IndexedDB: Keep direction on IDBCursor to avoid calls to back end
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Joshua Bell
Reported 2012-06-27 17:03:16 PDT
IndexedDB: Keep direction on IDBCursor to avoid calls to back end
Attachments
Patch (20.33 KB, patch)
2012-06-27 17:06 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (20.51 KB, patch)
2012-06-29 11:05 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.50 KB, patch)
2012-06-29 13:25 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-06-27 17:06:57 PDT
Created attachment 149825 [details] Patch
Joshua Bell
Comment 2 2012-06-27 17:10:43 PDT
alecflett@ - can you take a look? I think this is the last of the simple ones. IDBTransactionBackendInterface::mode() will be difficult to remove as IDBObjectStoreBackendInterface is passed a IDBTransactionBackendInterface (for example). We'll have to solve the "XXXImpl objects deserve XXXImpl pointers" problem to clean that up.
Joshua Bell
Comment 3 2012-06-27 17:14:07 PDT
alecflett@ - also, I'm not sure why IDBCursor::stringToDirection() was an unsigned int rather than an enum value. Changing it didn't seem problematic (other than having to pick a default in the error case), and was necessary for making IDBRequest::setCursorTypeAndDirection() accept the enum w/o a cast. Speaking of, the name setCursorTypeAndDirection() is wordy. setCursorInfo() ? setCursorDetails() ?
Alec Flett
Comment 4 2012-06-29 10:24:23 PDT
LGTM with extra const'ness on member variables
Joshua Bell
Comment 5 2012-06-29 11:05:25 PDT
Created attachment 150218 [details] Patch
Joshua Bell
Comment 6 2012-06-29 11:06:02 PDT
(In reply to comment #4) > LGTM with extra const'ness on member variables Added to IDBCursor::m_direction, also (based on offline discussion) went with setCursorDetails()
Joshua Bell
Comment 7 2012-06-29 11:06:21 PDT
tony@ - r?
Tony Chang
Comment 8 2012-06-29 11:28:10 PDT
Comment on attachment 150218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150218&action=review > Source/WebCore/Modules/indexeddb/IDBCursor.h:62 > + static IDBCursor::Direction stringToDirection(const String& modeString, ExceptionCode&); Nit: I don't think you need the IDBCursor:: prefix here.
Joshua Bell
Comment 9 2012-06-29 13:24:35 PDT
(In reply to comment #8) > > + static IDBCursor::Direction stringToDirection(const String& modeString, ExceptionCode&); > > Nit: I don't think you need the IDBCursor:: prefix here. Apparently it is needed, otherwise it's trying to resolve WebCore::Direction - the return type part of the function declaration is outside the IDBCursor scope, or some such.
Joshua Bell
Comment 10 2012-06-29 13:25:08 PDT
Created attachment 150244 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-06-29 20:09:49 PDT
Comment on attachment 150244 [details] Patch for landing Clearing flags on attachment: 150244 Committed r121612: <http://trac.webkit.org/changeset/121612>
WebKit Review Bot
Comment 12 2012-06-29 20:09:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.