Bug 90108

Summary: [chromium] Use SkColor in compositor internals
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch enne: review+

James Robinson
Reported 2012-06-27 16:20:50 PDT
[chromium] Use SkColor in compositor internals
Attachments
Patch (36.51 KB, patch)
2012-06-27 16:22 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (36.51 KB, patch)
2012-06-27 16:53 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-06-27 16:22:11 PDT
Created attachment 149813 [details] Patch
James Robinson
Comment 2 2012-06-27 16:33:28 PDT
Comment on attachment 149813 [details] Patch Hmm, this passes unit / layout tests, but appears to make some things in aura render badly (i.e. the bottom tray thingy is solid black instead of transparent sometimes). Will investigate...
James Robinson
Comment 3 2012-06-27 16:48:21 PDT
Comment on attachment 149813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149813&action=review > Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:41 > - if (m_color.hasAlpha()) > + if (SkColorGetA(m_color)) This is the bug with ash - hasAlpha() and SkColorGetA(color) are not the same thing - an alpha value of 0 definitely does _not_ mean the quad is opaque.
James Robinson
Comment 4 2012-06-27 16:53:26 PDT
Created attachment 149822 [details] Patch
Adrienne Walker
Comment 5 2012-06-27 18:15:36 PDT
Comment on attachment 149822 [details] Patch R=me.
James Robinson
Comment 6 2012-06-27 19:03:35 PDT
Committed r121396: <http://trac.webkit.org/changeset/121396>
Note You need to log in before you can comment on or make changes to this bug.