Bug 90103

Summary:

[chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater

Product:

WebKit

Reporter:

Dana Jansens <danakj>

Component:

New Bugs

Assignee:

Dana Jansens <danakj>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cc-bugs, enne, jamesr, piman, webkit.review.bot, wjmaclean, zlieber

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Dana Jansens

Reported 2012-06-27 15:15:12 PDT

[chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater

Attachments
Patch (23.74 KB, patch) 2012-06-27 15:23 PDT, Dana Jansens	no flags	Details Formatted Diff Diff
Patch for landing (23.74 KB, patch) 2012-06-28 08:05 PDT, Dana Jansens	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dana Jansens

Comment 1 2012-06-27 15:23:06 PDT

Adrienne Walker

Comment 2 2012-06-27 18:07:26 PDT

Comment on attachment 149804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149804&action=review Eep. Nice catch! One small nit, but otherwise R=me. > Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:61 > + if (contentsWidthScale != 1.0 || contentsHeightScale) { != 1.0 ??

Dana Jansens

Comment 3 2012-06-27 18:23:24 PDT

Comment on attachment 149804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149804&action=review ty :) >> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:61 >> + if (contentsWidthScale != 1.0 || contentsHeightScale) { > > != 1.0 ?? er.. nice catch yourself! oops!

Dana Jansens

Comment 4 2012-06-28 08:05:15 PDT

Created attachment 149956 [details] Patch for landing

Dana Jansens

Comment 5 2012-06-28 09:47:36 PDT

Note You need to log in before you can comment on or make changes to this bug.