Summary: | x86 disassembler confuses immediates with addresses | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2012-06-27 14:35:09 PDT
Created attachment 149797 [details]
the patch
Attachment 149797 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space after ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:112: Extra space before ) [whitespace/parens] [2]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 149797 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/121374 |