Bug 90073

Summary: Use floating keyframe rule list when parsing @-webkit-keyframes and allow abrupt rule termination
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: CSSAssignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hyatt, kling, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Alexander Pavlov (apavlov)
Reported 2012-06-27 06:57:52 PDT
Currently, a StyleRuleKeyframes instance is created in the empty alternative of "keyframes_rule", which makes use of the left recursion. This is inconsistent with the current approach of "floating" lists used when parsing sequences of other objects (selectors, rules in a block rule, etc.) and requires complex constructs to implement the sourcecode data extraction for keyframes rules. Also, the current grammar does not allow the abrupt termination of a @-webkit-keyframes rule (i.e. a missing closing brace), which is required by http://www.w3.org/TR/CSS21/syndata.html#parsing-errors (see bug 89980, which treats the same issue about the @font-face rule).
Attachments
Patch (8.14 KB, patch)
2012-06-28 03:36 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (8.16 KB, patch)
2012-06-28 04:56 PDT, Alexander Pavlov (apavlov) 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-06-28 03:36:48 PDT
Created attachment 149915 [details] Patch
Build Bot
Comment 2 2012-06-28 04:52:21 PDT
Comment on attachment 149915 [details] Patch Attachment 149915 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13118005
Alexander Pavlov (apavlov)
Comment 3 2012-06-28 04:56:50 PDT
Created attachment 149927 [details] Patch
Antti Koivisto
Comment 4 2012-06-29 01:31:48 PDT
Comment on attachment 149927 [details] Patch r=me
Alexander Pavlov (apavlov)
Comment 5 2012-06-29 01:56:07 PDT
Committed r121531: <http://trac.webkit.org/changeset/121531>
Note You need to log in before you can comment on or make changes to this bug.