Bug 90022

Summary:

[Chromium] Skia <canvas> should respect webkitBackingStorePixelRatio

Product:

WebKit

Reporter:

Stephen White <senorblanco>

Component:

Canvas

Assignee:

Stephen White <senorblanco>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

dglazkov, jamesr, schenney, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

83635

Bug Blocks:

Attachments:

Description	Flags
early draft, not for review	none
Archive of layout-test-results from ec2-cr-linux-02	none
Archive of layout-test-results from ec2-cr-linux-03	none
handle premul/unpremul in putImageData(), fix getImageData() clearing tests	none
Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL()	none
Remove LayoutTestController changes	none
Patch	none

Stephen White

Reported 2012-06-26 16:00:54 PDT

Skia <canvas> should respect webkitBackingStorePixelRatio. It should scale up the ImageBuffers which are created, and scale up the base transform applied to drawing commands to compensate.

Attachments
early draft, not for review (14.81 KB, patch) 2012-06-26 16:06 PDT, Stephen White	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (700.17 KB, application/zip) 2012-06-26 18:50 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cr-linux-03 (757.65 KB, application/zip) 2012-06-26 20:04 PDT, WebKit Review Bot	no flags	Details
handle premul/unpremul in putImageData(), fix getImageData() clearing tests (16.05 KB, patch) 2012-06-27 09:28 PDT, Stephen White	no flags	Details Formatted Diff Diff
Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL() (18.49 KB, patch) 2012-06-28 12:07 PDT, Stephen White	no flags	Details Formatted Diff Diff
Remove LayoutTestController changes (14.17 KB, patch) 2012-06-28 13:35 PDT, Stephen White	no flags	Details Formatted Diff Diff
Patch (14.68 KB, patch) 2012-07-26 13:22 PDT, Stephen White	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Stephen White

Comment 1 2012-06-26 16:06:33 PDT

Created attachment 149623 [details] early draft, not for review

WebKit Review Bot

Comment 2 2012-06-26 18:50:20 PDT

Comment on attachment 149623 [details] early draft, not for review Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13102568 New failing tests: canvas/philip/tests/2d.imageData.get.source.outside.html platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html

WebKit Review Bot

Comment 3 2012-06-26 18:50:24 PDT

Created attachment 149664 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 4 2012-06-26 20:04:35 PDT

Comment on attachment 149623 [details] early draft, not for review Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13093671 New failing tests: canvas/philip/tests/2d.imageData.get.source.outside.html platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html

WebKit Review Bot

Comment 5 2012-06-26 20:04:39 PDT

Created attachment 149670 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Stephen White

Comment 6 2012-06-27 09:28:06 PDT

Created attachment 149762 [details] handle premul/unpremul in putImageData(), fix getImageData() clearing tests

Stephen White

Comment 7 2012-06-28 12:07:41 PDT

Created attachment 149983 [details] Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL()

Stephen White

Comment 8 2012-06-28 13:35:36 PDT

Created attachment 149997 [details] Remove LayoutTestController changes

James Robinson

Comment 9 2012-06-28 13:42:37 PDT

I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome. It's a short-term hack that will stick around in the web platform long after its usefulness has expired.

Stephen White

Comment 10 2012-06-28 13:50:14 PDT

(In reply to comment #9) > I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome. It's a short-term hack that will stick around in the web platform long after its usefulness has expired. Yes, I agree. To be honest, I'd be happier not to land this, if that's the consensus.

James Robinson

Comment 11 2012-06-28 13:56:21 PDT

Comment on attachment 149997 [details] Remove LayoutTestController changes R- for now, then. (FWIW, the code looks pretty good but I'd want to take a really careful look at the rounding cases if we decide we do want to go forward with this).

Stephen White

Comment 12 2012-07-26 13:22:32 PDT

Created attachment 154731 [details] Patch

Note You need to log in before you can comment on or make changes to this bug.