Bug 90015

Summary:

Enable AVCF hardware video decoding

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

feature-media-reviews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	buildbot: commit-queue-
Updated patch.	buildbot: commit-queue-
Updated patch, again.	none
Fix the style-bot nit.	andersca: review+

Eric Carlson

Reported 2012-06-26 14:31:00 PDT

AVFoundationCF supports hardware video decoding on some systems, we should enable it when possible.

Attachments
Proposed patch (32.84 KB, patch) 2012-07-09 09:28 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Updated patch. (32.14 KB, patch) 2012-07-09 10:11 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Updated patch, again. (32.15 KB, patch) 2012-07-09 10:40 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Fix the style-bot nit. (32.15 KB, patch) 2012-07-09 11:44 PDT, Eric Carlson	andersca: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2012-06-26 14:31:15 PDT

<rdar://problem/10770317>

Eric Carlson

Comment 2 2012-07-09 09:28:39 PDT

Created attachment 151256 [details] Proposed patch

WebKit Review Bot

Comment 3 2012-07-09 09:31:50 PDT

Attachment 151256 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:981: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/WebCore/platform/win/SoftLinking.h:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 4 2012-07-09 09:51:27 PDT

Comment on attachment 151256 [details] Proposed patch Attachment 151256 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13167270

Eric Carlson

Comment 5 2012-07-09 10:11:33 PDT

Created attachment 151265 [details] Updated patch.

WebKit Review Bot

Comment 6 2012-07-09 10:14:26 PDT

Attachment 151265 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/win/SoftLinking.h:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 7 2012-07-09 10:25:21 PDT

Comment on attachment 151265 [details] Updated patch. Attachment 151265 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13156963

Eric Carlson

Comment 8 2012-07-09 10:40:47 PDT

Created attachment 151272 [details] Updated patch, again.

WebKit Review Bot

Comment 9 2012-07-09 10:43:30 PDT

Attachment 151272 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/win/SoftLinking.h:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 10 2012-07-09 11:44:12 PDT

Created attachment 151288 [details] Fix the style-bot nit.

Anders Carlsson

Comment 11 2012-07-10 09:59:04 PDT

Comment on attachment 151288 [details] Fix the style-bot nit. View in context: https://bugs.webkit.org/attachment.cgi?id=151288&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3485 > +GraphicsDeviceAdapter* HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter(const MediaPlayer*) const It's a little ugly to have this be on the HTMLMediaElement, but I can't think of a better solution.

Eric Carlson

Comment 12 2012-07-14 19:22:00 PDT

http://trac.webkit.org/changeset/122676

Note You need to log in before you can comment on or make changes to this bug.